On Fri, 24 Mar 2023 08:05:19 GMT, Eirik Bjorsnos <[email protected]> wrote:
>> test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 177:
>>
>>> 175: Path zip) throws IOException
>>> {
>>> 176:
>>> 177: Files.deleteIfExists(zip);
>>
>> Is this needed? I think I would just call the cleanup method from the setup
>> method
>
> Sparse files need to be created as such. The purpose of this delete exists to
> make this explicit. I moved this closer to the FileChannel.open and added a
> comment to explain the delete.
I am fine leaving it, but still not convinced it is needed if the setup method
calls the cleanup method and should achieve the same result. Again no big deal.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1147515419
