On Tue, 4 Apr 2023 19:31:24 GMT, Roger Riggs <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> test/jdk/java/util/regex/RegExTest.java line 967:
>
>> 965: for (int i=0; i<1000; i++) {
>> 966: char c = (char)generator.nextInt();
>> 967: check("{javaLowerCase}", c, isLowerCase(c));
>
> There are more readable with the explicit Character class reference; with
> them one has to hunt around for the named method. It also makes it explicit
> what is being tested.
I thought it was apparent since this is testing the *Character* properties and
reduces the complexity, but if you think so maybe not. Reverting static import
as I don't have a strong opinion on it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13314#discussion_r1157717351
