On Thu, 6 Apr 2023 03:17:37 GMT, ExE Boss <d...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/share/classes/jdk/internal/util/Architecture.java line 37:
>
>> 35: public enum Architecture {
>> 36: X64(), // Represents AMD64 and X86_64
>> 37: X86(),
>
> Suggestion:
>
> X86_64(), // Represents AMD64 and X86_64
> X86_32(),
The underscores are too ugly and X86 and X64 are well accepted names for those
architectures.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1159804212
