On Wed, 19 Apr 2023 17:32:49 GMT, Mahendra Chhipa <[email protected]> wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> closed file handlers.
Looks good overall
test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 89:
> 87: }
> 88: if(!Files.exists(Path.of(filePath,
> jdkVersion+"t"+FILENAME_DURATION ))) {
> 89: DatatypeFactory dtf = DatatypeFactory.newInstance();
Probably share the factory rather than creating one in each loop and twice.
-------------
PR Review: https://git.openjdk.org/jdk/pull/13537#pullrequestreview-1392731286
PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1171758806
