On Fri, 21 Apr 2023 16:25:04 GMT, Jan Lahoda <[email protected]> wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
>> - qualified enum constants are supported for case labels.
>>
>> This change herein also includes removal record patterns in for each loop,
>> which may be split into a separate PR in the future.
>
> Jan Lahoda has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Adding test.
> - Removing redundant continue, as noted on the review.
src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 808:
> 806: }
> 807:
> 808: public static int hashCode(int excludeComponent, Type
> recordType, Type[] fullComponentTypes, PatternDescription... nested) {
this argument: `fullComponentTypes` is not being used in this method, could be
removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13074#discussion_r1174066885
