On Mon, 24 Apr 2023 11:46:57 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use al instead of ValueLayout.ADDRESS
>
> src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line
> 142:
>
>> 140: // since the linker already restricts those such that they will
>> always be the same
>> 141: return switch (ml) {
>> 142: case StructLayout sl ->
>> MemoryLayout.structLayout(stripNames(sl.memberLayouts()));
>
> shouldn't names be also stripped from enclosing struct/union/sequence?
That should already happen because we're recreating the layout here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13562#discussion_r1175260317
