On Mon, 24 Apr 2023 12:28:37 GMT, Chen Liang <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added links to JVMS and utility methods moved to ConstantUtils
>
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 34:
>
>> 32: * <p>To create a {@linkplain PackageDesc} for a package, use {@link
>> #of} or
>> 33: * {@link #ofInternalName(String)}.
>> 34: *
>
> Needs a link to jvms 4.4.12. Same for ModuleDesc (4.4.11)
fixed, thanks.
> src/java.base/share/classes/java/lang/constant/PackageDescImpl.java line 37:
>
>> 35: * @throws IllegalArgumentException if the package name is invalid
>> 36: */
>> 37: public static String validateBinaryPackageName(String name) {
>
> All these utility methods should be moved to ConstantUtils.
fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1175262182
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1175265741
