On Tue, 25 Apr 2023 21:45:57 GMT, Mandy Chung <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update ModuleDesc.java
>> - Update PackageDesc.java
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java line 32:
>
>> 30: * A nominal descriptor for a {@code Module} constant.
>> 31: *
>> 32: * @apiNote
>
> can drop `@apiNote` as it's not needed to be. `<p>` if you want to a new
> paragraph.
Set back to `<p>` as suggested, thanks.
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 32:
>
>> 30: * A nominal descriptor for a {@code Package} constant.
>> 31: *
>> 32: * @apiNote
>
> can drop `@apiNote` as it's not needed to be. `<p>` if you want to a new
> paragraph.
Set back to `<p>` as suggested, thanks.
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 70:
>
>> 68: * @throws IllegalArgumentException if the name string is not in the
>> 69: * correct format
>> 70: * @jvms 4.2.1 Binary Class and Interface Names
>
> Worth adding `@jvm 4.2.3 Module and Package Names`
Added, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1177640205
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1177639109
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1177639506
