On Tue, 9 May 2023 09:03:09 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct Platform.is64Bit() to report address size of the architecture
>> enum, not the running system
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 65:
>
>> 63: */
>> 64: public boolean is64Bit() {
>> 65: return arch != Architecture.X86;
>
> Have you considered having an instance `Architecture::is64bit` method in lieu
> of the current static method?
Possibly, if a need subsequently arises.
The only current use is in CDSPlugin and it is testing if the current/runtime
platform is 64-bit so it can create the non-oop archive. The
`Architecture.is64bit()` provides that. The current `Platform.is64Bit()`
method is not needed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13585#discussion_r1188656539
