On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs <[email protected]> wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The checks of the os.version are replaced but may not be needed if OpenJDK
>> no longer supports them.
>>
>> It is recommended to remove os version checks that apply only to Mac
>> versions before 10.15.
>> Mac OS X 10.15 is the oldest version supported.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor source code style cleanup
src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51:
> 49: Log.info(I18N.getString("MSG_Help_no_args"));
> 50: } else {
> 51: OperatingSystem platform = OperatingSystem.current();
Should we add if (Log.isVerbose) back? Otherwise default case in switch
statement never executed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13586#discussion_r1192826773
