Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage

[Andrey Turbanov]

On Fri, 21 Apr 2023 17:28:54 GMT, Roger Riggs <rri...@openjdk.org> wrote:

> Refactor the Platform class in jdk.jpackage to use the internal 
> OperatingSystem, Architecture, and Version classes.
> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace 
> comparisons in the Platform class.
> The checks of the os.version are replaced but may not be needed if OpenJDK no 
> longer supports them.
> 
> It is recommended to remove os version checks that apply only to Mac versions 
> before 10.15.
> Mac OS X 10.15 is the oldest version supported.

src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java 
line 134:

> 132:                 CLIOptions.LAUNCHER_AS_SERVICE));
> 133: 
> 134:         if (OperatingSystem.isWindows())  {

Suggestion:

        if (OperatingSystem.isWindows()) {

src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java 
line 144:

> 142:         }
> 143: 
> 144:         if (OperatingSystem.isLinux())  {

Suggestion:

        if (OperatingSystem.isLinux()) {

src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java line 106:

> 104: 
> 105:         put(CLIOptions.FILE_ASSOCIATIONS.getId(),
> 106:             (OperatingSystem.isMacOS()) ?  USE.ALL : USE.INSTALL);

Suggestion:

            (OperatingSystem.isMacOS()) ? USE.ALL : USE.INSTALL);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13586#discussion_r1185750234
PR Review Comment: https://git.openjdk.org/jdk/pull/13586#discussion_r1185750325
PR Review Comment: https://git.openjdk.org/jdk/pull/13586#discussion_r1185750040