On Mon, 22 May 2023 08:53:21 GMT, Richard Reingruber <[email protected]> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup imports, improve comments, updates from other platforms.
>
> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java
> line 65:
>
>> 63: */
>> 64: public abstract class CallArranger {
>> 65: protected abstract boolean useABIv2();
>
> This could also be refactored into a static method with the same trick that
> is used in `LinuxPPC64leLinker::getInstance`. Callers could be static then
> and you could delete `CallArranger::ABIv2` and `ABIv2CallArranger`.
Maybe something like?
protected static final boolean useABIv2 = CABI.current() ==
CABI.LINUX_PPC_64_LE;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1200432599
