On Sun, 28 May 2023 03:57:40 GMT, Kim Barrett <[email protected]> wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1163:
>
>> 1161: #if defined(__clang__)
>> 1162: #pragma clang diagnostic push
>> 1163: #pragma clang diagnostic ignored "-Wparentheses"
>
> I think this warning is because of the several `if (init_result = ...)`?
> Better would be to just add the extra parens.
done
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 575:
>
>> 573: if (ps_pdread(ph, (char *)link_map_addr + LINK_MAP_LD_OFFSET,
>> 574: &lib_ld, sizeof(uintptr_t)) != PS_OK) {
>> 575: #else
>
> What problem is being "fixed" by these? I'm dubious that this is the best
> solution to whatever the problem
> is, but can't evaluate or suggest alternatives without knowing what it is.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1211733228
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1211732832
