On Fri, 2 Jun 2023 18:41:57 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> As mentioned in https://bugs.openjdk.org/browse/JDK-8308916 the expression >> should be `PreviewFeatures.isEnabled() && isSynthetic() && >> isTopLevelClass()` as `PreviewFeatures.isEnabled()` is a private static >> final test that will effectively make the full expression constant `false` >> when not in preview mode. > > Checking package access should also have near-zero cost. Will this accidentally return `true` for classes from other JVM programming languages? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1214969195
