On Mon, 5 Jun 2023 01:11:54 GMT, Joe Darcy <da...@openjdk.org> wrote:
> Document existing behavior. > > Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415 src/java.base/share/classes/java/lang/System.java line 758: > 756: * <td>Greatest Java class file format version recognized by the > runtime as {@code "MAJOR.MINOR"} > 757: * where {@link java.lang.reflect.ClassFileFormatVersion#major() > MAJOR} and {@code MINOR} > 758: * are both formatted as decimal integers</td></tr> I'm not sure about using the adjective "Greatest" here, only because "Greatest ... recognized" reads a bit like recognition of greatness when it really wants to convey that it's the highest version recognized. Does the wording need to take account of running with preview features enabled? The table uses "Java runtime" rather than "runtime" in the description of some of the other properties. In passing, should the descriptions of RELEASE_xxx in ClassFileFormatVersion say "The highest version recognized" rather than the "The version recognized"? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14305#discussion_r1217548926
