On Fri, 9 Jun 2023 17:40:58 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   newline at end of test file
>
> test/jdk/java/net/URL/HandlersPkgPrefix/LargeClasspathWithPkgPrefix.java line 
> 115:
> 
>> 113:     // javac -d <destDir> <javaFile>
>> 114:     private static void compile(Path javaFile, Path destDir) throws 
>> Exception {
>> 115:         String javacPath = JDKToolFinder.getJDKTool("javac");
> 
> FYI.   `jdk.test.lib.compiler.CompilerUtils` can be used to compile classes 
> in process.

Thank you Mandy, this is useful, I wasn't aware of this one. I have now updated 
the test to use this utility class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14395#discussion_r1224951220

Reply via email to