On Mon, 26 Jun 2023 20:54:42 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> simplify equals by replacing if with and operators > > src/java.base/share/classes/java/lang/invoke/MemberName.java line 995: > >> 993: return result; >> 994: ReflectiveOperationException ex = >> result.makeAccessException(); >> 995: if (ex instanceof IllegalAccessException iae) throw iae; > > Suggestion: > > if (ex instanceof IllegalAccessException iae) throw iae; Don't know why, but sometimes JDK devs leaves 2 spaces for certain breaks (like Joe Darcy tends to leave 2 for sentence breaks in Javadocs). Can anyone explain why? In MemberName in particular, I see a mix of 2 and 1 spaces for single-line if statements, so I will take your suggestion. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14642#discussion_r1242852444
