On Fri, 7 Jul 2023 17:15:38 GMT, Mandy Chung <[email protected]> wrote:
>> Chen Liang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since the last revision:
>>
>> Fix broken null behaviors
>
> test/jdk/java/lang/invoke/MethodHandleProxies/WithSecurityManagerTest.java
> line 54:
>
>> 52: } catch (Throwable ex) {
>> 53: throw new AssertionError("Test failed for " + cl, ex);
>> 54: }
>
> Nit: formatting - try block inside the for-loop
> Suggestion:
>
> for (Class<?> cl : List.of(Runnable.class, Client.class,
> NestedInterface.class)) {
> try {
> Object o = MethodHandleProxies.asInterfaceInstance(cl,
> originalMh);
> testWrapperInstanceTarget(o, originalMh);
> testWrapperInstanceType(o, cl);
> } catch (Throwable ex) {
> throw new AssertionError("Test failed for " + cl, ex);
> }
> }
This has the downside that any error will not run any later tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13197#discussion_r1259716091
