On Fri, 14 Jul 2023 16:42:02 GMT, Alan Bateman <[email protected]> wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address another case from feedback
>> - Address feedback
>
> src/java.base/share/classes/java/nio/charset/Charset.java line 987:
>
>> 985:
>> 986: /**
>> 987: * {@return the string describing this charset}
>
> You've changed this to "the string", which hints of ==, I think it should be
> reverted to a "a string".
Never understood this a/the difference in doc comments, thanks for explaining
it.
> src/java.base/unix/classes/sun/nio/fs/UnixPath.java line 713:
>
>> 711:
>> 712: return Arrays.equals(this.path, thisPos, thisLen, that.path,
>> thatPos,
>> 713: thatLen);
>
> My comment here was "thatLen" ended up on its own line, it can go after
> thatPos without making it too long.
That was surprising considering how picky you are about being on the shorter
side of line widths. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14886#discussion_r1264042654
PR Review Comment: https://git.openjdk.org/jdk/pull/14886#discussion_r1264044071
