On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato <na...@openjdk.org> wrote:
> This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. This looks quite good. I think Console::isTerminal works as a method name but we might have to iterate a bit on the javadoc to more clearly define it. For the CSR I think the behavior change to call out is that System::console will return a Console for cases where it didn't previously (at least not by default) and that will be observed by code that assumes non-null means isatty, cue the new method to provide a standard way to test this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14271#issuecomment-1638243162
