On Mon, 17 Jul 2023 21:31:33 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which refactors more java.util.Locale tests to JUnit >> with some minor cleanup as well. >> >> Although some of the files could benefit from being renamed bugNNNNNNN to >> something more descriptive, this makes reviewing harder, and will be handled >> separately. > > Justin Lu has updated the pull request incrementally with six additional > commits since the last revision: > > - Review: Explicitly run via othervm and pass locale args in cmdline > - Review: ws removal in Bug8179071.java > - Review: remove redudant 'throws' > - Review: Use assertTrue() in Bug8179071.java > - Review: Revert "Same as prev commit" > > This reverts commit 933c0312ed2fa0f40a750e950c166b7e820df7ab. > - Review: Revert "Remove try catch in Bug8135061.java" > > This reverts commit f213c74e37ed257a05a535b2c077af327343acb5. LGTM ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14881#pullrequestreview-1533749099
