On Wed, 9 Aug 2023 00:21:55 GMT, Weibing Xiao <d...@openjdk.org> wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > update method name and test case test/jdk/com/sun/jndi/ldap/SocketCloseTest.java line 81: > 79: > 80: public static class CustomSocketFactory extends SocketFactory { > 81: public static CustomSocket customSocket = new CustomSocket(); you can make 'customSocket' to private. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15143#discussion_r1287937502
