On Thu, 24 Aug 2023 18:08:13 GMT, Mark Sheppard <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Less specific error message, could be ports or other failure..
>
> test/jdk/sun/tools/jstatd/JstatdTest.java line 327:
>
>> 325: int tries = 0;
>> 326: try {
>> 327: while (jstatdThread == null && ++tries <= 10) {
>
> maybe use a ubiquitous constant MAX_RETRY (private static final in MAX_RETRY
> = 10)
Yes, agreed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15414#discussion_r1304892510
