On Tue, 29 Aug 2023 15:31:03 GMT, Sean Coffey <coff...@openjdk.org> wrote:

>> Recursive initialization calls possible during loading of LoggerFinder 
>> service.  
>> 
>> This fix detects the recursive call and returns a temporary LoggerFinder 
>> that is backed by a lazy logger. Automated test case developed to simulate 
>> loading of an external LoggerFinder service while also having other threads 
>> poke System.getLogger during this framework initialization.
>
> Sean Coffey has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   more tidying up in tests

test/jdk/java/lang/System/LoggerFinder/SignedLoggerFinderTest/SignedLoggerFinderTest.java
 line 214:

> 212:     private static Runnable runnableWithSleep(Supplier s, long sleep, 
> String desc) {
> 213:         return () -> {
> 214:             while(!testComplete) {

Suggestion:

            while (!testComplete) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1309949039

Reply via email to