On Mon, 28 Aug 2023 17:42:34 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy up SignedLoggerFinderTest.java >> - Code contribution from Daniel included. New tests. Fix up extra service >> call issues > > test/jdk/java/lang/System/LoggerFinder/RecursiveLoading/PlatformRecursiveLoadingTest.java > line 65: > >> 63: >> logs.stream().map(SimpleLogRecord::of).forEach(System.out::println); >> 64: >> logs.stream().map(SimpleLogRecord::of).forEach(SimpleLogRecord::check); >> 65: assertEquals(String.valueOf(logs.size()), String.valueOf(2));*/ > > Why is this code commented? Is it an oversight? BTW: With the modification suggested below in SimpleLoggerFinder, note that the expected number of messages should be 3 (not 2). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1307772571
