On Tue, 5 Sep 2023 21:14:00 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Removing unnecessary commas
>
> src/java.base/share/classes/java/text/ListFormat.java line 90:
> 
>> 88:  * method specifies the delimiting patterns for the start/middle/end 
>> portion of
>> 89:  * the formatted string, as well as optional specialized patterns for 
>> two or three
>> 90:  * elements. Refer to the method description for more detail.
> 
> Suggestion:
> 
>  * Alternatively, more flexible patterns can be constructed from the pattern 
> parts for the start, middle, 
>  * and end of the formatted list as well as specialized patterns for lists of 
> two or three elements.
>  * Refer to the {@link #getInstance(String[])} method description for more 
> detail.

For this part, I would not use `patterns` in the first suggested sentence but 
use `more flexible ListFormat instances` instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15130#discussion_r1316476327

Reply via email to