On Fri, 8 Sep 2023 10:24:22 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix library name
>
> src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.java
> line 42:
>
>> 40: private static boolean tryLoadLibrary() {
>> 41: return java.security.AccessController.doPrivileged(
>> 42: new java.security.PrivilegedAction<>() {
>
> Could use imports instead of using fully qualified names here.
No - problem here is that AccessController is deprecated for removal - so if we
import that, we'll get a warning on the import.
> src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.java
> line 45:
>
>> 43: public Boolean run() {
>> 44: try {
>> 45: System.loadLibrary("jimage");
>
> `"jimage"`?
whoops :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15633#discussion_r1319695373
PR Review Comment: https://git.openjdk.org/jdk/pull/15633#discussion_r1319694933
