On Tue, 5 Sep 2023 18:13:39 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> 温绍锦 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains four additional commits since >> the last revision: >> >> - Merge branch 'master' into optimization_for_decimal_to_string >> - BigInteger use a separate jla >> - update copyright info >> - optimization for decimal to string > > I think there is way too much duplication of logic going on here, primarily > with `StringLatin1.getChars(long, int, byte[])` (assuming #14699 is accepted > in the current state where `Integer.getChars(int, int, byte[])` and > `Long.getChars(...)` is moved there). Perhaps the bulk of this could be moved > to `StringLatin1` and then exposed via e.g. `JavaLangAccess`. > > On the motivation side I think it'd be helpful if you could point to some > larger benchmarks, frameworks et.c. where optimizing `BigDecimal::toString` > makes a significant difference. There has been some recent optimizations that > remove the need for `BigDecimal::toString` for some code paths, e.g., #9410 - > does this alleviate the need for this optimization or is this still useful or > even critical? @cl4es I have pushed a new commit to reduce duplicate code ------------- PR Comment: https://git.openjdk.org/jdk/pull/15555#issuecomment-1711562590
