On Thu, 7 Sep 2023 16:57:20 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporating suggested changes > > src/java.base/share/classes/java/text/ListFormat.java line 95: > >> 93: * On parsing, if some ambiguity is found in the input string, such as >> delimiting >> 94: * sequences being found in the input string, may produce the result >> that when formatted is not a >> 95: * round-trip with the corresponding formatting. For example, a two >> element String list > > Suggestion: > > * On parsing, if some ambiguity is found in the input string, such as > delimiting > * sequences in the input string, the result, when formatted with the same > formatting, does not > * re-produce the input string . For example, a two element String list Thanks, Roger. Incorporated. > src/java.base/share/classes/java/text/ListFormat.java line 345: > >> 343: * of Object. >> 344: * @param toAppendTo where the text is to be appended >> 345: * @param pos Ignored. Not used in ListFormat. May be null > > Curious, why not used? > I could see a use to identity the string inserted to enable highlighting or > other markup around the new string. `FieldPosition` is dedicated to identifying fields in *Format classes which are either `Format.Field` or fields that have names ending with "_FIELD", which ListFormat has neither of them. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15130#discussion_r1318969734 PR Review Comment: https://git.openjdk.org/jdk/pull/15130#discussion_r1318969680
