On Fri, 8 Sep 2023 21:06:25 GMT, ExE Boss <d...@openjdk.org> wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> lo | hi => hi | lo > > src/java.base/share/classes/java/util/HexDigits.java line 66: > >> 64: */ >> 65: @Stable >> 66: private static final short[] DIGITS; > > Maybe it should be `char[]` instead since it’s encoded using unsigned 16‑bit > integers.
a char would confuse people that each char represents one character, while it represents 2 in fact. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14745#discussion_r1320429120
