On Wed, 13 Sep 2023 19:40:04 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which is a continuation of >> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused >> code from the _sun.util.Calendar_ classes. >> >> `forceStandardTime` is always false. >> >> In addition, `locale` is never by used by _CalendarDate_ or any inheritors >> and can be removed. >> >> As a result, _ImmutableGregorianDate_ no longer needs to override the >> _setLocale_ method and throw UnsupportedOperationException. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Remove isStandardTime() and inline as false src/java.base/share/classes/sun/util/calendar/AbstractCalendar.java line 170: > 168: // adjust time zone and daylight saving > 169: int[] offsets = new int[2]; > 170: if (date.isStandardTime()) { This seems a little suspicious considering `isStandardTime()` is always false. However, at this point, there shouldn't be any behavioral changes probably. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15726#discussion_r1324987799
