On Thu, 14 Sep 2023 16:30:21 GMT, Brian Goetz <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> magic moved to Util::isAttributeAllowed and fixed possible NPE
>
> src/java.base/share/classes/jdk/internal/classfile/AttributeMapper.java line
> 117:
>
>> 115: * {@return attribute stability indicator}
>> 116: */
>> 117: AttributeStability attributeStability();
>
> Perhaps the name `stability()` would be better here because all the methods
> here are about the attribute being described.
Renamed, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15101#discussion_r1326391762
