On Sun, 17 Sep 2023 06:57:46 GMT, ExE Boss <d...@openjdk.org> wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix @Param due to the rename from default to class+method > > src/java.base/share/classes/java/lang/StackFrameInfo.java line 93: > >> 91: synchronized (this) { >> 92: if (type instanceof String sig) { >> 93: type = JLIA.getMethodType(sig, >> declaringClass().getClassLoader()); > > Maybe there should be a `return` here: > Suggestion: > > return type = JLIA.getMethodType(sig, > declaringClass().getClassLoader());
`type` is of type `Object`, don't think this compiles as the result type of `=` is the `type` variable's type. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1328057872