On Thu, 21 Sep 2023 05:26:38 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8315960: Address additional reviewer comments > > test/jdk/java/io/File/TempDirDoesNotExist.java line 142: > >> 140: OutputAnalyzer originalOutput = >> ProcessTools.executeTestJvm(options); >> 141: List<String> list = >> originalOutput.asLines().stream().filter(line >> 142: -> line.equalsIgnoreCase(WARNING)).toList(); > > You could use `count` instead of `toList`; the actual list is never used in > this test Fixed in cc4a3369871d8ad66162133e51bf625dfcf9b62c. > test/jdk/java/io/File/TempDirDoesNotExist.java line 143: > >> 141: List<String> list = >> originalOutput.asLines().stream().filter(line >> 142: -> line.equalsIgnoreCase(WARNING)).toList(); >> 143: if (list.size() != 1) > > Use assertEquals Fixed in cc4a3369871d8ad66162133e51bf625dfcf9b62c. > test/jdk/java/io/File/TempDirDoesNotExist.java line 148: > >> 146: >> originalOutput.asLines().toString()); >> 147: int exitValue = originalOutput.getExitValue(); >> 148: if (exitValue != 0) > > Use assertEquals Fixed in cc4a3369871d8ad66162133e51bf625dfcf9b62c. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1333256900 PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1333256321 PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1333256536
