On Fri, 22 Sep 2023 07:19:27 GMT, 温绍锦 <d...@openjdk.org> wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> restore HexDigits & OctalDigits
src/java.base/share/classes/java/util/FormatItem.java line 277:
> 275: this.hasPrefix = hasPrefix;
> 276: this.value = value;
> 277: this.length = HexDigits.INSTANCE.size(value);
Suggestion:
this.length = OctalDigits.INSTANCE.size(value);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15699#discussion_r1334053601
