On Fri, 22 Sep 2023 14:10:58 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Also, in the panama repo I see this: >> >> Allocates a memory segment with the given layout and initializes it with the >> bytes in the provided source memory segment. >> >> Which seems more correct - e.g. more consistent with other allocation >> methods, and also more succinct (note that the first sentence is really what >> shows up in the method summary javadoc, so there is a certain interest in >> providing a quick description of what the method does, > > Panama repo change: > https://github.com/openjdk/panama-foreign/commit/06e2017883c939188103c4dd53185417a00b2921 > > But, this code was altered in a follow up merge - maybe the merge was > problematic? This was changed in the main line repo as a result of: https://github.com/openjdk/jdk/pull/14997 Since all the other methods were using `{@return ...}` I changed this new overload to that style as well. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15103#discussion_r1334462650
