On Fri, 6 Oct 2023 20:54:34 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> addressing review comments, plus use URL for relative URI
>
> test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogTest.java line 509:
>
>> 507: @Test(expectedExceptions = NullPointerException.class)
>> 508: public void testFeatureNull() {
>> 509: CatalogResolver resolver =
>> CatalogManager.catalogResolver((CatalogFeatures)null, (URI)null);
>
> I misunderstood this change, as I thought this was for testing `null` for the
> *new* method. Should we have the equivalent one for the new method?
True, added a test. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16045#discussion_r1349365622
