On Fri, 13 Oct 2023 08:00:07 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
> Implement missing by-reference argument acquire/release functionality in > DowncallLinker::invokeInterpBindings. > > I've also simplified the related code a bit: > - `retIndexMap` was not used. I've removed it > - `BindingInterpreter.StoreFunc::store`'s type argument was not used. Removed > - UpcallLinker was redundantly collecting the move bindings for return > values. Removed > > I've added runs without specialization to the failing tests as well, so that > we keep testing this. > > Testing: `jdk_foreign` suite. Looks good ------------- Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16177#pullrequestreview-1676254470
