On Fri, 13 Oct 2023 10:21:06 GMT, Jorn Vernee <[email protected]> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve micro benchmarks and a comment.
>
> test/micro/org/openjdk/bench/java/lang/foreign/CLayouts.java line 68:
>
>> 66: * The layout for the {@code double} C type
>> 67: */
>> 68: public static final ValueLayout.OfDouble C_DOUBLE =
>> ValueLayout.JAVA_DOUBLE.withByteAlignment(IS_AIX ? 4 : 8);
>
> Would prefer if this used `Linker.canonicalLayouts`
> Suggestion:
>
> public static final ValueLayout.OfDouble C_DOUBLE =
> (ValueLayout.OfDouble) LINKER.canonicalLayouts().get("double");
I've improved the micro benchmarks with 3rd commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16179#discussion_r1358190616
