On Wed, 25 Oct 2023 09:05:11 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> This change fixes two errors in inline HTML styles in the `java.lang` >> package: >> >> - wrong CSS property name in `java.lang.String` >> - CSS declaration terminated by colon instead of semicolon in >> `java.lang.Thread` >> >> Both errors caused the style declarations to be ignored and an error message >> to be shown in the browser console. >> >> The bug is `noreg-doc`, I tested the docs in the browser to make sure the >> error message is gone and the HTML displays as intended. > > src/java.base/share/classes/java/lang/Thread.java line 192: > >> 190: * with the following system properties: >> 191: * <table class="striped"> >> 192: * <caption style="display:none;">System properties</caption> > > Just out of curiosity, is that semi-colon even needed, or would > `display:none` be enough? Now that I think about it, do you know why the `display:none` is being set here? I have very limited knowledge of CSS, wouldn't the use of `display:none` make the `System Properties` caption text invisible? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15762#discussion_r1371414879
