On Mon, 30 Oct 2023 13:43:13 GMT, Per Minborg <[email protected]> wrote:
>> This PR proposes removing the restriction that only heap `MemorySegment`
>> wrapping a `byte` array can be accessed by Vectors. Now any array type can
>> be used provided the element alignment constraints are respected.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add benchmark and intrinsification spy
test/jdk/jdk/incubator/vector/IntrinsicHeapTest.java line 48:
> 46: import static org.testng.Assert.*;
> 47:
> 48: public class IntrinsicHeapTest {
I don't think we need this test as part of this PR. It's useful ascertain what
is intrinsic or not. We can rethink it as part of the following fix if needed
to verify the intrinsics work across all the cross product of array types and
vector types.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16360#discussion_r1376494655
