On Thu, 2 Nov 2023 15:57:15 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> The test fails on windows because unmatched comparison of `Path.toString()` 
>> vs `URL.getPath().toString()` after JDK-8317965.   A simple fix is to 
>> evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does.
>
> Mandy Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   review feedback

TestLoadLibraryDeadlock.java: at line 144 after the creation of the jar files 
via method createJar, it would seem prudent to test that they actually exist at 
the expected location prior to executing the actual load tests, rather than 
purely relying createJar not throwing a RuntimeException ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16466#issuecomment-1791043721

Reply via email to