On Thu, 9 Nov 2023 07:54:39 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 216:
>
>> 214:
>> 215: /**
>> 216: * A function which accepts two intermediate states and combines
>> them into
>
> We could use a {@return ..} here. There might be other places too where we
> could do that.
Nit: I suggest using "A function that" rather than "A function which". One
peculiarity with the English language is the distinction between "that" (to be
used in a restrictive clause) and "which" (to be used in a non-restrictive
clause). Here is a reference:
https://preply.com/en/blog/when-to-use-which-or-that-the-most-common-cases
This comment also applies to documentation elsewhere.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387612537
