On Tue, 14 Nov 2023 17:25:42 GMT, Darragh Clarke <dcla...@openjdk.org> wrote:
>> Currently the `IsAlive` test occasionally times out. >> >> This PR changes the timeout from `10` to `25` which I think is an adequate >> increase based on the failures I've seen. Though I'd be happy to change it >> to another value if someone thinks `25` isn't ideal. > > Darragh Clarke has updated the pull request incrementally with one additional > commit since the last revision: > > use default timeout Yeah, OK. IIRC, we did the `/timeout=10` initially so that the eventual bug case would take less than 240*TIMEOUT_FACTOR seconds to complete and fail. But given the non-buggy execution should actually pass, and on overloaded machines it could take a while to get to termination, just using the default is fine. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16659#pullrequestreview-1734368948
