On Thu, 16 Nov 2023 18:30:46 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

> > We need to go through each plugin and decide on its behavior.
> 
> OK. I'll add documentation to the `--list-plugins` help should there be 
> deviations.

It'd be helpful if you write down your proposed behavior for each plugin for 
discussion.   Otherwise, we will have to find out from the code.

> > I'm also pondering how the Plugin API should support this run-time image 
> > based linking.
> 
> It could, but doesn't need to IMO. OTOH, `transform()` could grow an argument 
> to indicate packaged-modules vs runtime image link.

I'm not sure if it needs the extra argument.   As the plugin knows what files 
it adds, it can always check its existence as the current implementation is 
doing.   What I'm thinking if the plugin will need to indicate if it'd 
concatenate, retain or drop the transformation from `image1` when creating 
`image2.   This will get the plugin author to consider that when the plugin is 
developed.

Regarding the name of the `runimage_resources` file, this file is only used by 
jlink and so it can be a resource file in `jdk.jlink` module like 
`jdk.jlink/jdk/tools/jlink/internal/runtime/$MODULE_resources` (e.g. 
`jdk.jlink/jdk/tools/jlink/internal/runtime/java.base_resources`)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-1815100986

Reply via email to