Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

[Doug Lea]

On Wed, 22 Nov 2023 08:07:00 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:

>> Doug Lea has updated the pull request with a new target base due to a merge 
>> or a rebase. The incremental webrev excludes the unrelated changes brought 
>> in by the merge/rebase. The pull request contains three additional commits 
>> since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8319662
>>  - tweak cascades; reinstate an @Contended; resolve JDK-8319498
>>  - Support cascading idle timeouts
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2149:
> 
>> 2147:                 deadline - System.currentTimeMillis() < TIMEOUT_SLOP) {
>> 2148:                 long sp = w.stackPred & LMASK, c;
>> 2149:                 if ((nextPhase & SMASK) == ((int)(c = ctl) & SMASK)  &&
> 
> Suggestion:
> 
>                 if ((nextPhase & SMASK) == ((int)(c = ctl) & SMASK) &&

Thanks; done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16725#discussion_r1401900689