On Wed, 22 Nov 2023 18:35:33 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> src/hotspot/share/runtime/vm_version.cpp line 33:
>>
>>> 31: void VM_Version_init() {
>>> 32: VM_Version::initialize();
>>> 33: guarantee(VM_Version::supports_cx8(), "Support for 64-bit atomic
>>> operations in required in this release");
>>
>> Typo: "in required in". Also, no need to mention "this release" at all?
>> Suggestion for message: "JVM requires platform support for 64-bit atomic
>> operations"
>
> Or the simpler change:
> s/in required/is required/
Message tweaked: Support for 64-bit atomic operations is required
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16625#discussion_r1402877940
