On Fri, 24 Nov 2023 11:00:18 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove Test > > src/java.base/share/classes/java/lang/Class.java line 4797: > >> 4795: PublicMethods.MethodList res = getMethodsRecursive(name, >> parameterTypes, true, publicOnly); >> 4796: return res == null ? null : >> getReflectionFactory().copyMethod(res.getMostSpecific()); >> 4797: } > > Would you mind moving this up to follow getDeclaredPublicMethods, as these > are the two method finders exposed via JavaLangAccess. Updated > src/java.base/share/classes/jdk/internal/misc/MethodFinder.java line 40: > >> 38: } >> 39: >> 40: private static final JavaLangAccess JLA = >> SharedSecrets.getJavaLangAccess(); > > The new shared secret and usage looks fine. It would be good to add a short > class description and method description and make it clear it's for launcher > usage, we don't want this used for anything else. Personally I would move JLA > to to the top rather than after the constructor. Updated ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1404324242 PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1404324338
