On Mon, 27 Nov 2023 23:46:00 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Requested changes
>
> test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35:
>
>> 33: import java.lang.reflect.Modifier;
>> 34:
>> 35: public class TestImplicitClass {
>
> The test looks to be testing core reflection behavior (i.e. runtime behavior)
> and not compile-time behavior via javax.lang.model.
>
> Core reflection tests should be done too, but done the core libraries tests,
> not langtools tests.
>
> I might have overlooked it, but if some other exercise of compile-time
> modeling is not being done, please restore and update accordingly the sort of
> tests previously done in the now-deleted
>
> test/langtools/tools/javac/processing/model/element/TestUnnamedClass.java
Added
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1407907660
