On Mon, 27 Nov 2023 15:00:54 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> On the Property name: there is an existing System Property >> "sun.rmi.transport.connectionTimeout" which is a 15-second idle timeout. >> Having a "connectionTimeout" and this new one as "connectTimeout" could be >> confusing, even in different but very similar package names, hence naming >> this "initialConnectTimeout". >> (So "initial" to signal that it's the initial connect of a socket, different >> to the existing "connectionTimeout".) >> It does not seem like the kind of system property a user would expect to be >> read again on every usage, I think, let me know if you see that as a problem. >> >> I am hoping that as we already have various properties fetched in the same >> manner, we don't see the need to pursue a test that the value is fetched and >> passed on. > > Have you considered naming it "socketConnectTimeout" instead? Or possibly > "tcpConnectTimeout"? If you named it "tcpConnectTimeout" then you could name the (future) property for [JDK-8320703](https://bugs.openjdk.org/browse/JDK-8320703: JMX SSL RMI Socket connection timeout cannot be changed) "tlsConnectTimeout"... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16771#discussion_r1406309820
